Add autouse fixtures to restore server state in setFeatureCompatibilityVersion tests#668
Merged
eerxuan merged 2 commits intoJul 24, 2026
Conversation
Signed-off-by: Alina (Xi) Li <Alina.Li@improving.com>
alinaliBQ
marked this pull request as ready for review
July 7, 2026 19:09
documentdb-triage-tool
Bot
added
compatibility test
|
🤖 Auto-triaged by documentdb-triage-tool. Applied: Reasoningcomponent from path globs (test-coverage); effort from diff stats (33+4 LOC, 4 files); LLM: Fixes a test-isolation bug where failed FCV assertions leak mutated global state into subsequent tests, causing unreliable test results. If a label is wrong, remove it manually and ping |
eerxuan
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests that mutate global server FCV (setFeatureCompatibilityVersion) previously relied on inline restore calls
after assertions. If an assertion failed, the restore was skipped, leaking mutated state into every subsequent test.